-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type cast segments for derived types #149
Conversation
cc8e22f
to
4ee8e9e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6ed38d2
to
03b4ff6
Compare
03b4ff6
to
4c86e26
Compare
test/Microsoft.OpenAPI.OData.Reader.Tests/Operation/ODataTypeCastGetOperationHandlerTests.cs
Outdated
Show resolved
Hide resolved
Excuse me. But, Coding style, clean coding, making code readable... are my style. Thanks. |
The "Excuse me" part of this passive aggressive comment does not make it more acceptable. IDEs and people are going to have different configurations and preferences. If you care about tab, spaces, curlies and other details like that, please take the time to push a configuration that's enforced through tooling as described in #142 as as we've discussed offline. Now, can we focus on reviewing the code rather than the whites-pacing around the code please? |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
- adds support for query parameters when in navigation properties Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
- fixes a bug where cast would be missing for non contained properties after the key Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
… cast segments under collection segments Signed-off-by: Vincent Biret <[email protected]>
…ent types Signed-off-by: Vincent Biret <[email protected]>
…ed Ids Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Co-authored-by: Sam Xu <[email protected]>
Co-authored-by: Sam Xu <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
3e390b1
to
306e946
Compare
fixes #124
Summary
This pull request adds two new settings
EnableODataTypeCast
(default true) andRequireDerivedTypesConstraintForODataTypeCastSegments
(default true) and adds type cast segments for singletons, entity sets, entity set items (keys), navigation properties bound to a single item, navigation properties items (key) of types which have derived types.It also adds child type operations and child type navigation properties under the singleton, entity set item, single nav prop, and nav prop item cast segments.
It also adds count segments under cast segment that are under collection navigation properties and entity sets.
With examples:
It will read the derived type constraints annotations for example
The logic of whether the segments will be added or not can be exhaustively described with
Or segments will only be added when the option is enabled and either: