Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes response objects for operations that return single primitive type values #127

Merged
merged 5 commits into from
Nov 18, 2021
Merged

Fixes response objects for operations that return single primitive type values #127

merged 5 commits into from
Nov 18, 2021

Conversation

irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday commented Nov 17, 2021 •
edited
Loading

Fixes #126

This PR:

  • Fixes the schema of response objects of operations that return a single primitive type
  • Refactors common code that creates OpenApiResponses for IEdmOperations and IEdmOperationImports into a common function that can be reused by both.

@irvinesunday irvinesunday self-assigned this Nov 17, 2021
@irvinesunday irvinesunday merged commit 226ce62 into master Nov 18, 2021
@irvinesunday irvinesunday deleted the is/responses-with-primitive-types branch November 18, 2021 18:27
@baywet baywet added this to the 1.0.10 milestone Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peombwa peombwa peombwa approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
OData:1.0.10
Development

Successfully merging this pull request may close these issues.

CSDL to OpenAPI Translation of Responses with Primitive Values
3 participants
@irvinesunday @peombwa @baywet