Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and register email hash providers #630

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update and register email hash providers #630

wants to merge 5 commits into from

Conversation

rabbit0v0
Copy link
Contributor

Updated StaticSaltProvider to get salt from IOptions;
Update corresponding tests;
Remove unused logger in StaticSaltProvider;
Update ServiceCollectionExtensions to register correct services.

@rabbit0v0 rabbit0v0 marked this pull request as ready for review November 9, 2023 13:35
@rabbit0v0 rabbit0v0 requested a review from a team as a code owner November 9, 2023 13:35
artempushkin
artempushkin requested changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@artempushkin artempushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we probably have an internal implementation of this functionality that can be used instead. Once confirmed, this PR should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artempushkin artempushkin artempushkin requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabbit0v0 @artempushkin