Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐌 SNPE env and example fix #860

Merged
merged 9 commits into from
Jan 9, 2024
Merged

🐌 SNPE env and example fix #860

merged 9 commits into from
Jan 9, 2024

Conversation

trajepl
Copy link
Contributor

@trajepl trajepl commented Jan 8, 2024

Describe your changes

There are a few issues for current SNPE examples:

  1. The libxx.so under customized python3.6 need to be put visible for system for SNPE cmd running
    • put str(Path(f"{snpe_root}/python36-env/lib")) under LD_LIBRARY_PATH can fix.
  2. SNPE evaluation extent the logits wrongly,
    • fixed in this PR.
  3. We did not support tensorflow model evaluation.
    • update examples without input model evaluation.
  4. Wrong metrics config for inception examples
  5. Importing issue for vgg, tell that in README.md to let user update it manually as a workaround.
  6. Python3.6 seems a bit outdated for latest SNPE updates. The vgg example failed to be run. Updated the python env to 3.8 can fix.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
olive/snpe/create_python36_env.sh Outdated Show resolved Hide resolved
jambayk
jambayk previously approved these changes Jan 8, 2024
Copy link
Contributor

@jambayk jambayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. The lib and bin paths worked fine previously so I am not sure if it's something to do with the new snpe version or our environment differences. But it doesn't hurt to add extra paths.

@guotuofeng
Copy link
Collaborator

It seems the shellcheck fail, do we need fix it?

Copy link
Collaborator

@guotuofeng guotuofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need fix the shellcheck failure?

@trajepl
Copy link
Contributor Author

trajepl commented Jan 9, 2024

do we need fix the shellcheck failure?

Thanks! Added the Shebang info for shell script.

@trajepl trajepl merged commit 06e5c11 into main Jan 9, 2024
31 checks passed
@trajepl trajepl deleted the jiapli/snpe_py_env_fix branch January 9, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants