Arecibo backports #223
Merged
Arecibo backports #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simplified the NIFS struct in `nifs.rs` file by removing extraneous elements.
- Removed `EvaluationArgument` struct from `ipa_pc.rs` file, replacing it with direct usage of `InnerProductArgument`. - Updated `EvaluationEngineTrait` type declarations to accommodate the change. - Reworked `prove` and `verify` methods to work directly with `InnerProductArgument`. - Made `InnerProductArgument` visibility public.
- Trait bound changed from `PrimeField + PrimeFieldBits` to `PrimeField` in `poseidon.rs`.
- Refactored the `from_label` function in pasta.rs removing redundant collect, flatten operations and Vec<usize> creation,
- Optimized performance by refactoring the use of iterator `into_iter()` to the iterator itself in `gadgets/r1cs.rs`. - removed a clone in ppsnark.
srinathsetty
approved these changes
Aug 25, 2023
|
Thanks! This also addresses issue #202 |
|
@srinathsetty not completely, there's still some duplication between Pasta, on the one hand, and the Halo2curves-based implementations, on the other hand. |
srinathsetty
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small backports from Arecibo, please refer to the individual commit messages.