Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: IntuneAntivirusPolicyWindows10SettingCatalog Fixes 3818 and 3955 #3952

Merged
merged 4 commits into from
Nov 29, 2023
Merged

PR: IntuneAntivirusPolicyWindows10SettingCatalog Fixes 3818 and 3955 #3952

merged 4 commits into from
Nov 29, 2023

Conversation

William-Francillette
Copy link
Contributor

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

  • IntuneAntivirusPolicyWindows10SettingCatalog
    • Skipped settingValueTemplateReference and settingInstanceTemplateReference for severethreats, highseveritythreats, moderateseveritythreats, lowseveritythreats as per API requirements observed in the Intune portal
      FIXES #3818

ykuijs
ykuijs reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@ykuijs ykuijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

...ntivirusPolicyWindows10SettingCatalog/MSFT_IntuneAntivirusPolicyWindows10SettingCatalog.psm1 Show resolved Hide resolved
@William-Francillette
Copy link
Contributor Author

@ykuijs all sorted

@andikrueger
Copy link
Collaborator

@William-Francillette would this PR also address #3955 ?

@William-Francillette
Copy link
Contributor Author

@William-Francillette would this PR also address #3955 ?

@andikrueger just pushed the fix

@William-Francillette William-Francillette changed the title PR: IntuneAntivirusPolicyWindows10SettingCatalog Fixes 3818 PR: IntuneAntivirusPolicyWindows10SettingCatalog Fixes 3818 and 3955 Nov 29, 2023
@andikrueger andikrueger linked an issue Nov 29, 2023 that may be closed by this pull request
IntuneAntivirusPolicyWindows10SettingCatalog: Fails to extract settings #3955
Closed
@ykuijs ykuijs merged commit f44ba30 into microsoft:Dev Nov 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykuijs ykuijs ykuijs left review comments

@NikCharlebois NikCharlebois Awaiting requested review from NikCharlebois NikCharlebois is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@William-Francillette @andikrueger @ykuijs