Code cleanup #325
Code cleanup #325
Conversation
sungam3r
commented
Jan 14, 2024
•
sungam3r
commented
|
Some of these policies I'm going to disagree with because they match the internal coding styles we use. For example, we require use of |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
# Conflicts: # UnitTests/UnitTests.csproj
.editorconfig
Outdated
| dotnet_style_qualification_for_property = false:warning | ||
| dotnet_style_qualification_for_method = false:warning | ||
| dotnet_style_qualification_for_event = false:warning | ||
| csharp_style_namespace_declarations = file_scoped:suggestion |
There was a problem hiding this comment.
Our internal policy is block_scoped, so I would prefer that still.
BenchmarkTests/combine-bechmarks.csx
Outdated
| @@ -10,20 +10,20 @@ var resultsPath = Path.Combine(resultsDir, resultsFile + ".json"); | |||
|
|
|||
| if (!Directory.Exists(resultsDir)) | |||
| { | |||
| throw new DirectoryNotFoundException($"Directory not found '{resultsDir}'"); | |||
| throw new DirectoryNotFoundException($"Directory not found '{resultsDir}'"); | |||
There was a problem hiding this comment.
There are lots of spacing changes. What operation are you doing here, exactly?
There was a problem hiding this comment.
I changed indentation from tabs to spaces.
There was a problem hiding this comment.
ah....I'm actually surprised I didn't notice that. My IDE is set to spaces. Reasonable, thanks!
| using (var stream = this.manager.GetStream("Program.Main", this.sourceBuffer, | ||
| 0, this.sourceBuffer.Length)) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable Warning
.editorconfig
Outdated
| dotnet_style_qualification_for_field = true:warning | ||
| dotnet_style_qualification_for_property = false:warning | ||
| dotnet_style_qualification_for_method = false:warning | ||
| dotnet_style_qualification_for_event = false:warning |
There was a problem hiding this comment.
Sorry if I wasn't clear earlier. These should all be true.
