Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper arguments when constructing models in unit tests #408

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

xinyu-intel
Copy link

when contructing models in unit test, arguments need to be set. Take ParallelMLP() as an example, get_args() is used to get some args setted by user in the constructor func:

def __init__(self, config, moe=False, enable_expert_tensor_parallelism=False):
super(ParallelMLP, self).__init__()
args = get_args()

So, need to set_args() accordingly.

@xinyu-intel
Copy link
Author

cc @polisettyvarma

Copy link

@costin-eseanu costin-eseanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, approved.

@xinyu-intel
Copy link
Author

@tjruwase hi, can you please help on review?

@tjruwase
Copy link

tjruwase commented Jul 1, 2024

@tjruwase hi, can you please help on review?

@xinyu-intel, @costin-eseanu has already approved and will merge. Thanks!

@costin-eseanu costin-eseanu merged commit c3a13be into microsoft:main Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants