Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various changes to the
MK.IO
project, focusing on adding new test cases, improving validation, add RTMPS support, and enhancing the existing codebase. The most important changes include adding new test cases forAssetsOperations
andLiveEventsOperations
, enhancing validation methods inArgument.cs
, and introducing a new model classHlsSettings
.Test Enhancements:
MK.IO.Tests/AssetsOperationsTests.cs
: Added new test cases forCreate_AssetErrorInTags
,Create_AssetNoErrorInTags
, andCreate_DeserializationError
methods.MK.IO.Tests/LiveEventsOperationsTests.cs
: Introduced comprehensive test cases forLiveEventsOperations
, including tests for null, empty, and valid inputs, as well as deserialization and tag validation.Validation Improvements:
MK.IO/Argument.cs
:AssertNotLessThanLength
method to validate minimum length requirements.AssertJwtToken
method to useJsonWebTokenHandler
for better JWT validation.AssertTagsNullOrCompliant
method to validate tag entries.Codebase Enhancements:
MK.IO/Asset/AssetsOperations.cs
: Added new validations forcontainerName
,storageName
,description
,alternateId
, andlabels
in theCreateOrUpdateAsync
method.MK.IO/ContentKeyPolicy/ContentKeyPoliciesOperations.cs
: Added new validations forcontentKeyPolicyName
andproperties.Description
in theCreateAsync
method.New Model Class:
MK.IO/CsharpDotNet2/Model/HlsSettings.cs
: Introduced a new classHlsSettings
with propertiesCharacteristics
,Default
, andForced
.Minor Changes:
MK.IO/CsharpDotNet2/Model/JobOutputAsset.cs
: Set default value forProgress
property to 0.MK.IO/Argument.cs
: Changed import fromSystem.IdentityModel.Tokens.Jwt
toMicrosoft.IdentityModel.JsonWebTokens
.