Generate project.json in %TEMP% rather than in install location #332
Conversation
| # create the temp folder if it does not exist | ||
| $TempPath = Join-Path -Path $env:TEMP -ChildPath "getclrdbg" | ||
| if (-not (Test-Path -Path $TempPath -PathType Container)) { | ||
| New-Item -ItemType Directory -Force -Path $TempPath | ||
| } |
There was a problem hiding this comment.
Should you delete the folder if it exists? I'm a little concerned that the file gets cached somewhere I don't know about and may not realize the need to clean to get an update.
There was a problem hiding this comment.
The way project.json is generated, it will be recreated each time this script is run, nothing is cached.
There was a problem hiding this comment.
Got it, I see above it will override the contents regardless. Is there any other file that may be left behind that could be a problem? If not then no need to delete the folder.
There was a problem hiding this comment.
|
@gregg-miskelly yes. |
| New-Item -ItemType Directory -Force -Path $InstallPath | ||
| # create the temp folder if it does not exist | ||
| $TempPath = Join-Path -Path $env:TEMP -ChildPath "getclrdbg" | ||
| if (-not (Test-Path -Path $TempPath -PathType Container)) { |
There was a problem hiding this comment.
There is no point to having -PathType Container if you don't deal with having a file named 'getclrdbg'
|
lgtm |
chuckries
force-pushed
the
getclrdbg-release
branch
from
77c55ee to
f750cf8
Compare
|
Updated this to created a directory named from a new Guid under %temp% and also fixed an issue with giving the script a relative path as an install location. This should fix any caching/simultaneous use issues. |
| New-Item -ItemType Directory -Force -Path $InstallPath | ||
| # create the temp folder if it does not exist | ||
| $GuidString = [System.Guid]::NewGuid() | ||
| $TempPath = Join-Path -Path $env:TEMP -ChildPath $GuidString |
There was a problem hiding this comment.
If you are going to do it this way (which sounds reasonable to me) you should probably also delete the directory at the end of the script.
There was a problem hiding this comment.
With this change we generate the project.json in %temp%\<guid> and restore/publish from this directory into the final install directory. This avoids having the project.json in the final install directory.
chuckries
force-pushed
the
getclrdbg-release
branch
from
f750cf8 to
237affa
Compare
With this change we generate the project.json in %temp%\getclrdbg and
restore/publish from this directory into the final install directory. This
avoids having the project.json in the final install directory.