Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] documentation build test #958

Merged
merged 9 commits into from
Oct 3, 2017
Merged

[docs] documentation build test #958

merged 9 commits into from
Oct 3, 2017

Conversation

StrikerRUS
Copy link
Collaborator

This PR adds test at Travis for building documentation and verifying broken links in it.

@chivee chivee self-requested a review October 3, 2017 06:20
@chivee
Copy link
Collaborator

chivee commented Oct 3, 2017

look's fine to me, we should wait for #945 ready.

sslverify=0

[filtering]
ignore=
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chivee Thank you very much! Now all works fine without ignoring.

@StrikerRUS
Copy link
Collaborator Author

@chivee

we should wait for #945 ready.

This PR should be merged first for allowing automatic checking that one.

@@ -1,4 +1,4 @@
sphinx
sphinx<=1.5.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why <= 1.5.6 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because >1.5.6 it doesn't generate html: sphinx-doc/sphinx#3800

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I see.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I belive, after converting all things to rst we will be able to remove this restriction and uncomment html5 test (Sphinx 1.6 is expected to support htm5 writer) because at present it generates dozens of errors and warnings.

@chivee chivee merged commit 589541e into microsoft:master Oct 3, 2017
@StrikerRUS StrikerRUS deleted the docs branch October 4, 2017 09:39
guolinke pushed a commit that referenced this pull request Oct 9, 2017
* added doc test

* fixed 404

* prevented maito: ref creation

* added rst structure test

* fixed unknown directives

* added code for the future check for html syntax

* replaced problem link
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants