[cmake] consolidate set_target_properties() calls #6594
Conversation
jameslamb
changed the title
jameslamb
requested review from
guolinke,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
| lightgbm_objs _lightgbm | ||
| PROPERTIES | ||
| CUDA_ARCHITECTURES ${CUDA_ARCHS} | ||
| CUDA_SEPARABLE_COMPILATION ON |
There was a problem hiding this comment.
CUDA_SEPARABLE_COMPILATION was not set for _lightgbm target in previous config.
There was a problem hiding this comment.
ah! Thank you for catching that, I've updated it in recent commits.
This also led me to question what this property actually does. Here's a simple explanation of it: https://stackoverflow.com/a/50557765/3986677
| endif() | ||
| set_target_properties(_lightgbm PROPERTIES CUDA_RESOLVE_DEVICE_SYMBOLS ON) |
There was a problem hiding this comment.
This line was lost in new config.
There was a problem hiding this comment.
ah! Too many similarly-named properties 😂
Thank you for catching this, I've fixed that in recent commits.
|
Sure! I've been learning a lot about CMake lately, hoping to continue simplifying and improving LightGBM's CMake stuff. I'm especially interested in making LightGBM more friendly to build and link to for repackagers like @barracuda156 (see for example #6489). |
Another step towards simplifying this project's CMake configuration (are you sensing a theme in my recent PRs? 😂 ).
CMake's
set_target_properties()accepts multiple targets and multiple properties (CMake docs).This proposes taking advantage of that to consolidate a few calls.