Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the last few days, we've observed 2 CI issues which happen on every build triggered by a merge to
master
... but which do not happen on PRs.runtime error: member call on address 0x612000003ad8 which does not point to an object of type 'std::streambuf'
in macOS cpp_tests CI job #6543OSError: [WinError 122] The data area passed to a system call is too small
in Windows bdist CI job #6544Comparing logs between those types of builds, I found only 1 seemingly-significant difference between them... on builds triggered by merges to
master
, tasks calledInitialize CodeQL
andFinalize CodeQL
are automatically injected.This proposes trying to prevent those tasks from being injected. If we do that and see a few builds on
master
succeed, we'll be able to say with confidence that the CodeQL jobs were the issue.More context on how these jobs might cause the CI failures we've observed #6544 (comment)
Notes for Reviewers
Docs on where this comes from or how to turn it off?
I couldn't really find any. "Configure GitHub Advanced Security for Azure DevOps" (Azure DevOps docs) describes how to enable this scanning, but does not talk about auto-injection.
The variables I'm proposing adding to
.vsts-ci.yml
were found in other large projects' configs:dotnet/roslyn
(link)dotnet/sourcelink
(link)interpretml/interpret
(link)Microsoft/STL
(link)posit-dev/positron
(link)I'm not sure how those projects learned about them... I haven't yet found any documentation referencing them.
This is not the first time we've had to do something like this ... @StrikerRUS I remembered you something very similar back in November 2022: #5175.
How to test this
The only way to test this is to merge to
master
, as this behavior is only observable there.