-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] drop Python 3.6 support, add Python 3.12 #6459
Conversation
.github/workflows/cuda.yml
Outdated
cuda_version: "11.8.0" | ||
task: cuda | ||
- method: source | ||
compiler: gcc | ||
python_version: "3.9" | ||
python_version: "3.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proposing swapping this one and the wheel
task, so we're always testing newest CUDA together with newest Python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the review! For breaking changes like this, I'd like to try to get 2 reviews. @jmoralez I know you'd supported this general idea in #6375 (comment), could you take a look at this PR and let us know what you think about the choices I made here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
hmmmmm
I see this in the CMake logs:
It's surprising to see LightGBM linking against I'm gonna push a commit setting |
I'm moving the testing of the CUDA CI issue to a separate PR, I don't think it's related to this PR's changes: #6465 |
I've merged in #6465, which fixes the CUDA CI issues, and reverted all the debugging stuff I'd pushed here. Will merge this once CI (hopefully) passes. |
Inspired by this discussion: #6375 (comment)
Proposes the following:
python-requires
to>= 3.7
Notes for Reviewers
Why these versions?
I picked the oldest versions where
pip install
run in thepython:3.7
docker image found a wheel. Found that building those old versionsscipy
andpandas
from their sdists failed with a variety of errors.Summary:
cffi
= unchanged at1.15.1
(Jun 2022)numpy
= from1.16.6
(Dec 2019) to1.19.1
(Jul 2020)pandas
= from0.24.0
(Jan 2019) to1.1.3
(Oct 2020)pyarrow
= unchanged at6.0.1
(Nov 2021)scikit-learn
=0.18.2
(Jun 2017) to0.24.0
(Dec 2020)scipy
=0.19.0
(Mar 2017) to1.6.0
(Dec 2020)