Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate HDFS support #6443

Merged
merged 2 commits into from
May 7, 2024
Merged

deprecate HDFS support #6443

merged 2 commits into from
May 7, 2024

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented May 6, 2024

Contributes to #6436. See that issue for much more discussion.

This proposes deprecating HDFS support, for the reasons described in #6436. I'd like to get this into the next release (#6439) and then fully remove this support in a future release of LightGBM.

Notes for Reviewers

Since this is a proposal to eventually break a part of the public API, I would especially like a review on this (and #6436) from either @guolinke or @shiyu1994 .

How I tested this

I searched for these places like this:

git grep -i hdfs

And tested the deprecation warning like this:

cmake -B build -S . -DUSE_HDFS=ON

Saw it generated correctly.

CMake Deprecation Warning at CMakeLists.txt:289 (message):
  HDFS support in LightGBM is deprecated, and will be removed in a future
  release.  See https://github.com/microsoft/LightGBM/issues/6436.

@jameslamb
Copy link
Collaborator Author

thanks @guolinke !

@jameslamb jameslamb merged commit 88cec47 into master May 7, 2024
38 checks passed
@jameslamb jameslamb deleted the deprecate-hdfs branch May 7, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants