-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [python-package] enable ruff-format on tests and examples #6317
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bc3b186
[ci] [python-package] enable ruff-format on tests and examples
jameslamb 54c6a60
fix isort
jameslamb 215ae2d
imports
jameslamb 007ed34
revert config changes
jameslamb c8ec85a
ok I guess we do need the python-package/ imports
jameslamb 20a0db0
Merge branch 'master' into ci/more-ruff
jameslamb 7c75b2b
Merge branch 'master' into ci/more-ruff
jameslamb ab301a6
Merge branch 'master' into ci/more-ruff
jameslamb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposing moving
isort
up aboveruff
because they were fighting each other. I think it makes sense to haveisort
go first since it might do things like remove duplicate imports or re-group them, and thenruff
after which will simply reformat them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relevant conversation: astral-sh/ruff#8926 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nevermind this one, looks like this was a result of me addingprofile = "black"
to theisort
config while testing. Reverted that in 007ed34 andpython-package/
changes dropped out of the diff.Nope, guess we DO need to include
python-package/
, and a few other changes to the configuration forisort
to make it andruff
stop fighting each other. Sorry, was running this on the wrong branch before 😅