[python-package] remove CVBooster._append() #6057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
guolinke,
shiyu1994 and
jmoralez
as code owners
jameslamb
commented
Aug 22, 2023
| @@ -514,11 +510,11 @@ def _make_n_folds( | |||
| train_set, valid_set, tparam = fpreproc(train_set, valid_set, params.copy()) | |||
| else: | |||
| tparam = params | |||
| cvbooster = Booster(tparam, train_set) | |||
| booster_for_fold = Booster(tparam, train_set) | |||
There was a problem hiding this comment.
I found it confusing at first that this was named cvbooster but was not actually a CVBooster object.
Thought it made sense in the context of this PR to change this variable name.
guolinke
approved these changes
Aug 23, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes removing
CVBooster._append(). That method was a one-line wrapper around just appending directly toCVBooster.boosters... I don't think the additional indirection is worth it.This PR proposes removing that method to make the
cv()code a bit easier to understand.