Fix calculation of number of bins in FindGroup #6019
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CVPaul
requested review from
guolinke,
jameslamb,
shiyu1994 and
jmoralez
as code owners
|
@microsoft-github-policy-service agree |
|
@shiyu1994 could you please edit the title of this to make it more informative in the release notes? I would, but I don't really understand the effect of this PR. |
shiyu1994
changed the title
|
this would be great to have in any release soon, please 🙏 |
shiyu1994
approved these changes
Feb 8, 2024
I've just come across this issue. No release with this solution yet?? |
|
I also meet same problem. When release this version? |
|
Unfortunately, we are currently battling CI issues (cf. #6425). Once we got our GPU runners working again, we are planning to prepare another release -- this will likely happen in the early part of May. |
yuhorun
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3339.
The calculation method for num_total_bin used during Exclusive Feature Bundling
LightGBM/src/io/dataset.cpp
Line 134 in 665c473
(bin_mappers[fidx]->GetDefaultBin() == 0 ? -1 : 0);
doesn't align completely with the way num_total_bin is calculated during the creation of a FeatureGroup
LightGBM/include/LightGBM/feature_group.h
Line 68 in 665c473
if (bin_mappers_[i]->GetMostFreqBin() == 0) {
As a result, the max_bin_per_group (=256) is working during Bundling, but it is not working when creating the FeatureGroup. When I replaced the GetDefaultBin() at dataset.cpp#L134 with GetMostFreqBin(), the issue was resolved.