Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] fix broken links in docs #5939

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[docs] fix broken links in docs #5939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/.linkcheckerrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ threads=1
ignore=
pythonapi/lightgbm\..*\.html.*
http.*amd.com/.*
https.*tandfonline.com/.*
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm able to navigate to https://www.tandfonline.com/doi/abs/10.1080/01621459.1958.10501479 in my browser without issue, and without being signed in to that website.

image

But curl -I (which issues a HEAD request), returns a 403 - Access Denied.

(lgb-dev) 😬 ./LightGBM $ curl -I https://www.tandfonline.com/doi/abs/10.1080/01621459.1958.10501479
HTTP/2 403
date: Fri, 23 Jun 2023 04:59:22 GMT
content-type: text/html; charset=UTF-8
cross-origin-embedder-policy: require-corp
cross-origin-opener-policy: same-origin
cross-origin-resource-policy: same-origin
permissions-policy: accelerometer=(),autoplay=(),camera=(),clipboard-read=(),clipboard-write=(),geolocation=(),gyroscope=(),hid=(),interest-cohort=(),magnetometer=(),microphone=(),payment=(),publickey-credentials-get=(),screen-wake-lock=(),serial=(),sync-xhr=(),usb=()
referrer-policy: same-origin
x-frame-options: SAMEORIGIN
cf-mitigated: challenge
cache-control: private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0
expires: Thu, 01 Jan 1970 00:00:01 GMT
strict-transport-security: max-age=15552000
server: cloudflare
cf-ray: 7dba29492ca810b3-ORD
alt-svc: h3=":443"; ma=86400

Looks like that site is behind CloudFlare, so the link checks are probably triggering some anti-DDoS protection 🤷🏻

This configuration change tells the check-links CI job to ignore that domain.

A similar issue with amd.com links was fixed by doing this same thing in the past here:

ignorewarnings=http-robots-denied,https-certificate-error
checkextern=1

Expand Down
4 changes: 2 additions & 2 deletions docs/Parallel-Learning-Guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,6 @@ See `the mars documentation`_ for usage examples.

.. _the lightgbm_ray documentation: https://docs.ray.io/en/latest/tune/api_docs/integration.html#lightgbm-tune-integration-lightgbm

.. _Mars: https://docs.pymars.org/en/latest/index.html
.. _Mars: https://mars-project.readthedocs.io/en/latest/

.. _the mars documentation: https://docs.pymars.org/en/latest/user_guide/learn/lightgbm.html
.. _the mars documentation: https://mars-project.readthedocs.io/en/latest/user_guide/learn/lightgbm.html