Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add quantized training paper to docs #5923

Merged
merged 4 commits into from
Jun 15, 2023
Merged

Conversation

jameslamb
Copy link
Collaborator

Contributes to #5606.

Adds the quantized training paper to the README alongside other papers.

@shiyu1994 @guolinke are there any others you'd like me to add?

@guolinke
Copy link
Collaborator

Thank you!

README.md Outdated
@@ -145,6 +145,8 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
Reference Papers
----------------

Yu Shi, Guolin Ke, Zhuoming Chen, Shuxin Zheng, Tie-Yan Liu. "Quantized Training of Gradient Boosting Decision Trees" ([link](https://papers.nips.cc/paper_files/paper/2022/file/77911ed9e6e864ca1a3d165b2c3cb258-Paper-Conference.pdf)). Advances in Neural Information Processing Systems 35 (NeurIPS 2022), pp. 18822-18833.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw once that linking directly to the PDF was kind of rude, maybe it should point to: https://papers.nips.cc/paper_files/paper/2022/hash/77911ed9e6e864ca1a3d165b2c3cb258-Abstract.html instead? I see the two below do exactly that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine with me.

Updated in 6e59758.

For my own knowledge... what's rude about it? Just that clicking it could trigger a download instead of opening a tab in your browser?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I saw it in a tweet from Andrej Karpathy but it was something like that. Some phones automatically download the file, also you may just want to read the abstract before actually going to the paper.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiiinteresting. Ok yeah makes sense to me! Thanks for telling me about that 😊

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for necroposting. I accidentally found this thread and think it might be useful to provide a link to detailed answer for those who come here from search engines.

https://physics.meta.stackexchange.com/a/11401

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, thanks very much for sharing this!

That answer is fantastic. I just added it to my bookmarked list of things to share in PR reviews, appreciate you sharing it!

@jameslamb jameslamb requested a review from jmoralez June 14, 2023 20:38
@jameslamb jameslamb merged commit a323c75 into master Jun 15, 2023
@jameslamb jameslamb deleted the docs/more-papers branch June 15, 2023 00:41
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants