Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] remove unnecessary Boost files from sdists #5912

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

jameslamb
Copy link
Collaborator

Contributes to #5061.

The OpenCL-based GPU builds of LightGBM rely on the Boost headers included in the repo

set(BOOST_COMPUTE_HEADER_DIR ${PROJECT_SOURCE_DIR}/external_libs/compute/include)

but link against already-compiled Boost libraries, expected to be pre-installed.

find_package(Boost 1.56.0 COMPONENTS filesystem system REQUIRED)

As a result, the only Boost files that need to be packaged in sdists are the headers in external_libs/compute/include. This PR proposes removing the other Boost files, to reduce the size of sdists and the time it takes to build them.

@jameslamb jameslamb requested a review from jmoralez June 8, 2023 03:29
@jameslamb jameslamb changed the title WIP: [python-package] remove unnecessary Boost files from sdists [python-package] remove unnecessary Boost files from sdists Jun 8, 2023
@jameslamb jameslamb marked this pull request as ready for review June 8, 2023 03:47
@jameslamb jameslamb merged commit fe69fa9 into master Jun 8, 2023
@jameslamb jameslamb deleted the remove-unnecessary-files branch June 8, 2023 13:17
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants