-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update Quick Start #5900
Conversation
Make `lightgbm` command executable on command line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your interest in LightGBM abd for taking the time to contribute.
Can you please explain how this change "makes lightgbm
executable"? Did you experience some error following the instructions as currently written? What was it?
As a general rule, I think you'll find your proposed changes here (and in other open source projects) are more likely to be accepted if you explain how they improve the project. Without such explanation, you're asking reviewers to guess, which increases the effort required to review.
This term "executable" is used figuratively. Sorry about that. It's just that the Installation Guide allows to install Using double quotes made it even more wishing for a change. All in all, I made the simple changes for two reasons:
HTH ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhhh ok! Very good point that these docs would be incompatible with other methods like brew install
for the CLI.
Thanks for that explanation. Given that, I totally support this change.
Don't worry about the failing CI jobs... they are not a result of your changes. See #5898 and #5899 for more details. Once we're able to fix those (and this project's CI), I'll come back and merge this. Sorry for the inconvenience.
I've updated this branch with the latest changes from |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Make
lightgbm
command executable on command line