[ci] [python-package] fix mypy error about return_cvbooster in cv() #5845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3867.
Fixes the following error from
mypy
.That error is raised because
mypy
(correctly) infers that the return value forcv()
is aDict[str, List[float]]
here:LightGBM/python-package/lightgbm/engine.py
Line 704 in f74875e
LightGBM/python-package/lightgbm/engine.py
Lines 746 to 748 in f74875e
But then it tries to add an item that is a
CVBooster
here:LightGBM/python-package/lightgbm/engine.py
Lines 765 to 766 in f74875e
I think just
#type: ignore
-ing this error is preferable to other possible fixes like:results
toDict[str, Any]
(which would reducemypy
's ability to catch issues in the main update loop incv()
return {**results, 'cvbooster': cvfolds}
, which would add to the peak memory usage for runningcv()
by temporarily copyingresults