Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quantized training (CPU part) #5800

Merged
merged 31 commits into from
May 5, 2023
Merged

Add quantized training (CPU part) #5800

merged 31 commits into from
May 5, 2023

Conversation

shiyu1994
Copy link
Collaborator

This is to add the quantized training for CPU, which speed up the training. (#5606)

@shiyu1994
Copy link
Collaborator Author

It is weird that the test_monotone_penalty_max fails in this commit [6a76fde], which doesn't seem to have any changes that will cause the failure. This should call for further attention to check if the test case fails randomly in some cases. Maybe we should simply make this test case more deterministic by setting the number of threads to be 1 or enable the deterministic flag.

(6a76fde)
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=14615&view=logs&j=c28dceab-947a-5848-c21f-eef3695e5f11&t=fa158246-17e2-53d4-5936-86070edbaacf

@shiyu1994
Copy link
Collaborator Author

@guolinke This is ready for review.

@shiyu1994
Copy link
Collaborator Author

@guolinke This is ready for review.

Sorry I think one more test case for distributed quantized training should be added in test_dask.py. Please pending the review until that is ready.

@shiyu1994
Copy link
Collaborator Author

shiyu1994 commented May 5, 2023

@guolinke This is ready for review.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants