Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] [dask] add type annotations on dask._HostWorkers #5766

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

jameslamb
Copy link
Collaborator

Contributes to #3756.
Contributes to #3867.
Split from #5765.

Proposes replacing the use of collections.namedtuple for one internal class in the Dask module with a regular Python class, so that informative type annotations can be added.

This makes it a bit clearer, when reading the code, what the values of that class's attributes should be (unlike namedtuple, which is just a collection of attribute names).

I chose to use a regular Python class instead of dataclasses.dataclass to preserve support for Python 3.6 (#5765 (comment)), and chose to avoid typing.NamedTuple (https://stackoverflow.com/a/50038614/3986677) to reduce the risk of incompatibilities caused by future updates to typing.

@jameslamb
Copy link
Collaborator Author

thanks @jmoralez !

@jameslamb jameslamb merged commit bf1a604 into master Mar 7, 2023
@jameslamb jameslamb deleted the ci/mypy-dask-host-workers branch March 7, 2023 04:51
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants