Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [python-package] [ci] move some configuration to setup.cfg #5762

Closed
wants to merge 1 commit into from

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Mar 3, 2023

Contributes to #5061 .
Reduces the number of changes that need to be reviewed when switching build backends for the Python package (work-in-progress in #5759).

This PR proposes moving some configuration for the Python package out of setup.py and into a setup.cfg file. This moves the project one step closer to having PEP 517 / 518 compliant Python package builds.

For reference, see:

@jameslamb jameslamb mentioned this pull request Mar 3, 2023
60 tasks
@jameslamb
Copy link
Collaborator Author

blegh I guess I misunderstood, and you can't mix some arguments supplied via setup.py and others via setup.cfg the way I was trying here. I'll close this, sorry.

@jameslamb jameslamb closed this Mar 3, 2023
@jameslamb jameslamb deleted the python/setup-cfg branch March 3, 2023 03:51
@microsoft microsoft locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant