WIP: [ci] include lightgbm's dependencies in linting job #5746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756
Contributes to #3867.
The
lint
CI job runsmypy
, a static type-checker for Python.The code in
python-package/compat.py
handles optional imports by creating placeholder empty classes and functions. For example, like this:LightGBM/python-package/lightgbm/compat.py
Line 25 in 39ed8ea
Since many of
lightgbm
's dependencies (likepandas
andmatplotlib
) are not currently installed during thelint
CI job, it's those placeholder definitions thatmypy
checks. And the presence of# type: ignore
comments on many of them short-circuits the type-checking process.As a result, the
lint
job is currently not able to detect issues like "pandas Series do not have attribute.xyz
".This PR proposes installing all of those dependencies in the
lint
CI job, to improve the ability of CI to catch such incompatibilities (at least with the latest version of all installed dependencies).