[python-package] remove default values in internal functions #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
StrikerRUS,
shiyu1994 and
jmoralez
as code owners
guolinke
approved these changes
Feb 26, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposes removing default argument values in the following internal functions:
Dataset.__init_from_seqs()Booster.__inner_eval()_format_eval_result()_make_n_folds()_check_not_tuple_of_2_elements()_float2str()Removing defaults helps to prevent "forgot to pass arguments through" types of bugs.
Notes for Reviewers
This PR is just about changing reliance on default values, and isn't intended to actually change LightGBM's behavior. If you see any places with a user-facing change, please note them so I can revert them.