Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] fix mypy errors about padded eval_results #5716

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[dask] fix mypy errors about padded eval_results #5716

merged 2 commits into from
Feb 15, 2023

Conversation

jameslamb
Copy link
Collaborator

Contributes to #3867.

Fixes the following mypy errors.

python-package/lightgbm/dask.py:166: error: Incompatible types in assignment (expression has type "str", target has type "Dict[str, List[Any]]")  [assignment]
python-package/lightgbm/dask.py:168: error: Incompatible types in assignment (expression has type "str", target has type "Dict[str, float]")  [assignment]

@jameslamb jameslamb requested a review from jmoralez as a code owner February 15, 2023 04:32
@jameslamb jameslamb requested a review from StrikerRUS February 15, 2023 04:33
@jameslamb jameslamb merged commit 6f0bc48 into master Feb 15, 2023
@jameslamb jameslamb deleted the dask-eval-hints branch February 15, 2023 19:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jmoralez jmoralez jmoralez approved these changes

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameslamb @jmoralez