-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [R-package] fix clang 15 warning about unqualified calls (fixes #5661) #5662
Conversation
🎉 adding https://github.com/microsoft/LightGBM/actions/runs/3842093698/jobs/6543052842 I'll continue by pushing a fix to LightGBM here. Now we'll have high confidence that if that job passes here, it'll pass on CRAN too. |
/gha run r-valgrind Workflow R valgrind tests has been triggered! 🚀 Status: success ✔️. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix.
Thanks @shiyu1994 ! I'll open a PR for a v3.3.5 release tonight. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Fixes #5661.
std::move()
explicitly instead of ausing
declaration, to satisfyclang
's-Wunqualified-std-cast-call
warningclang
15 in ther-devel-debian-clang
job, to more closely match CRAN's environment (see Inconsistencies with CRAN fedora-clang-devel r-hub/rhub-linux-builders#63 (comment))Notes for Reviewers
The installation commands I'm proposing are based on https://apt.llvm.org/llvm.sh, the installation script recommended at https://apt.llvm.org/.
I think copying that stuff in here is safer than downloading a script from the internet and running it on every run.