Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [R-package] fix clang 15 warning about unqualified calls (fixes #5661) #5662

Merged
merged 7 commits into from
Jan 5, 2023

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Jan 4, 2023

Fixes #5661.

Notes for Reviewers

The installation commands I'm proposing are based on https://apt.llvm.org/llvm.sh, the installation script recommended at https://apt.llvm.org/.

I think copying that stuff in here is safer than downloading a script from the internet and running it on every run.

@jameslamb jameslamb added the fix label Jan 4, 2023
@jameslamb
Copy link
Collaborator Author

🎉 adding clang-15 to the CI job, I was able to exactly replicate the issue reported on CRAN.

https://github.com/microsoft/LightGBM/actions/runs/3842093698/jobs/6543052842

I'll continue by pushing a fix to LightGBM here. Now we'll have high confidence that if that job passes here, it'll pass on CRAN too.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Jan 5, 2023

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/3843870737

Status: success ✔️.

@jameslamb jameslamb changed the title WIP: [ci] [R-package] fix clang 15 warning about unqualified calls (fixes #5661) [ci] [R-package] fix clang 15 warning about unqualified calls (fixes #5661) Jan 5, 2023
@jameslamb jameslamb marked this pull request as ready for review January 5, 2023 05:42
Copy link
Collaborator

@shiyu1994 shiyu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@jameslamb
Copy link
Collaborator Author

Thanks @shiyu1994 ! I'll open a PR for a v3.3.5 release tonight.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R-package] CRAN issue with unqualified call to 'std::move'
2 participants