[python-package] remove Dataset.feature_penalty
#5656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
StrikerRUS,
shiyu1994 and
jmoralez
as code owners
jameslamb
changed the title
Dataset.feature_penalty
jmoralez
approved these changes
Jan 12, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5313.
Proposes removing public attribute
Dataset.feature_penalty. It was added in #2006 to support methodDataset.get_feature_penalty().Dataset.get_feature_penalty()was removed in #2594, which movedfeature_penaltyintoparams(instead of having it be a top-level attribute ofDataset).Notes for Reviewers
This is technically "breaking" because it removes a public attribute that user code could reference, but this attribute doesn't actually do anything and hasn't since
get_feature_penalty()was removed back in #2594.So I chose the label
maintenance, to not add more noise to thebreakingsection of the release notes for something that I think very few users are likely to be depending on.