fix feature index in Dataset::AddFeaturesFrom (fixes #5410) #5650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5434.
Fixes #5410.
Thanks to @EdmondElephant for discovering this bug, investigating it in #5410, and for fixing it in #5434!
I'm just replacing that PR with this one due to lack of response there (it has been more than 3 months since the last comment there).
Notes for Reviewers
I ran the following to test that this new unit test segfaults on
master
and passes on this PR.