Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update CPU dockerfiles (fixes #5550) #5601

Merged
merged 9 commits into from
Dec 29, 2022
Merged

Conversation

jameslamb
Copy link
Collaborator

Fixes #5550.

The Dockerfiles in docker/ can be used to build container images for running different builds of LightGBM. It's

This PR proposes some changes to the non-GPU Dockerfiles there, to hopefully make them easier to use, especially for people who are new to LightGBM.

  • updates from Ubuntu 16.04 (entered only-getting-security-patches mode in 2021) to Ubuntu 20.04
  • installs OpenMP in every image
  • ensures that you can copy, paste, and run examples with 0 modification
  • switches from CMake-based build of the R package to CRAN-style package, since it's less likely to have installation issues
  • other misc. minor cleanup (like indentation so flags in docker run are easier to read)

Copy link
Collaborator

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Just some optional removals of the interactive terminal.

docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
docker/README.md Outdated Show resolved Hide resolved
@jameslamb
Copy link
Collaborator Author

removals of the interactive terminal

Thanks for that! You're right, for these cases the -it for docker run was unnecessary. Just applied those suggestions, I'll merge this once CI builds.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake error at linking process while integrating lightgbm
2 participants