-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] prefix several internal functions with _ #5545
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for your help with this! Please see the one suggestion I made.
I also made two changes to this PR:
- listed the specific changes object names in the description (since the PR title saying "multiple" isn't enough to indicate which objects you intended to change)
- made the PR title slightly more specific so it will be a bit easier for people reading the release notes to understand what this PR did
Also, I noticed that you did one commit per object. That's totally fine if that helped you to organize your thoughts, but if you worked that way for the benefit of LightGBM, I want to let you know you don't need to do that extra work here in the future. This project uses squash merging, which means that all of the changes from a PR are combined into a single commit on master
when the PR is merged.
Co-authored-by: James Lamb <[email protected]>
Thanks for the hints @jameslamb! I will arrange the future changes for this issue than in less commits and mention the changed definitions explicitly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! We'll merge this once we fix the project's CI issues (unrelated to your PR).
@Madnex sorry for the delay! We've now fixed the project's CI issues. Sorry for the inconvenience, but could you please merge the latest changes from Thanks so much for your continued help with LightGBM! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #5313, by prefixing the following internal functions in
lightgbm.basic
with_
:cfloat32_array_to_numpy()
cfloat64_array_to_numpy()
cint32_array_to_numpy()
cint64_array_to_numpy()
c_str()
is_1d_list()
list_to_1d_numpy()
cfloat32_array_to_numpy()