[R-package] fix test on non-ASCII features in non-UTF8 locales #5526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
jmoralez
approved these changes
Oct 8, 2022
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #5502.
One test on LightGBM's treatment of non-ASCII features has been failing on the
r-devel-linux-x86_64-debian-clangCRAN check flavor recently (see #5502).This PR fixes that test.
Shouldn't this be on release v3.3.3?
These changes do need to make it into the emergency patch release we're preparing (#5525). But this issue exists on
masteras well.How does this change help?
Through the investigation on #5502, I found some evidence that
{testthat}was somehow modifying R's handling of this one test in non-UTF8 locales: #5502 (comment).I believe that could be related to some combination of:
{lightgbm}'s use of non-ASCII string literals in a test source file{testthat}changing encodings when reading source code of test files (testthat code link){testthat}changing some locale settings (testthat code link)How I tested this
Ran the R package's unit tests inside the image built from r-hub/rhub-linux-builders#62, which should closely match the failing CRAN check.
Doesn't this totally fix the r-devel-debian-clang issue?
Not quite. #5502 should stay open until LightGBM's CI is again using a daily build of the
rhub/debian-clang-develimage. Hopefully my PR to fix that upstream will be accepted.