Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Add Huber regression objective for cuda_exp #5462

Merged
merged 28 commits into from
Sep 2, 2022

Conversation

shiyu1994
Copy link
Collaborator

Add Huber regression objective for cuda_exp.

add test cases for regression objectives
@shiyu1994 shiyu1994 requested a review from jmoralez as a code owner September 2, 2022 06:07
CHECK_GT(num_machines, 1);
tree->SetLeafOutput(i, 0.0);
n_nozeroworker_perleaf[i] = 0;
if (boosting_on_cuda_) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove boosting_on_cuda_ in future, and always boost on CUDA?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. After we implement all objectives in CUDA, we will remove boosting_on_cuda_ for cuda_exp.

@shiyu1994 shiyu1994 merged commit 45c53f7 into master Sep 2, 2022
@shiyu1994 shiyu1994 deleted the cuda/objective-regression branch September 2, 2022 12:28
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants