[CUDA] Add lambdarank objective for cuda_exp #5453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
reviewed
Sep 2, 2022
src/objective/objective_function.cpp
Outdated
| @@ -39,7 +40,7 @@ ObjectiveFunction* ObjectiveFunction::CreateObjectiveFunction(const std::string& | |||
| return new CUDABinaryLogloss(config); | |||
| } else if (type == std::string("lambdarank")) { | |||
| Log::Warning("Objective lambdarank is not implemented in cuda_exp version. Fall back to boosting on CPU."); | |||
guolinke
reviewed
Sep 2, 2022
| } | ||
|
|
||
| template <data_size_t NUM_RANK_LABEL> | ||
| __global__ void GetGradientsKernel_LambdarankNDCG_Sorted( |
There was a problem hiding this comment.
differences compared with non sorted one?
There was a problem hiding this comment.
GetGradientsKernel_LambdarankNDCG_Sorted does not sort the items. GetGradientsKernel_LambdarankNDCG sorts the items in shared memory. These two are for different numbers of items in a query. When a query contains too many items, the sorting cannot be performed in shared memory. Thus a sorting is done separately, and then GetGradientsKernel_LambdarankNDCG_Sorted is used.
guolinke
approved these changes
Sep 3, 2022
StrikerRUS
reviewed
Sep 4, 2022
Co-authored-by: Nikita Titov <[email protected]>
Co-authored-by: Nikita Titov <[email protected]>
StrikerRUS
reviewed
Sep 4, 2022
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lambdarank objective for
cuda_exp(#5163).rank_xendcgwill be added forcuda_expafter this PR is merged.