[python-package] fix mypy error about type change in Dataset.feature_num_bin() #5447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3756.
Contributes to #3867.
mypy
currently raises the following error.This is caused by the fact that
mypy
doesn't allow changing the type of an object after it's initially assigned. This blog post explains it well: https://adamj.eu/tech/2021/05/23/python-type-hints-mypy-doesnt-allow-variables-to-change-type/.This PR proposes a slight refactoring of
Dataset.feature_num_bin()
to resolve this error. I think this change does also make the code slightly easier to understand.Notes for Reviewers
I tested this by running
mypy
as documented in #3867.mypy \ --exclude='python-package/compile/|python-package/build' \ --ignore-missing-imports \ python-package/