update tree to if-else

[jmoralez]

Updates the tree to if else code to match the code in tree.h:

• Numerical Split:

  LightGBM/include/LightGBM/tree.h

  Lines 335 to 353 in 6b695c2

  	inline int NumericalDecision(double fval, int node) const {
  	uint8_t missing_type = GetMissingType(decision_type_[node]);
  	if (std::isnan(fval) && missing_type != MissingType::NaN) {
  	fval = 0.0f;
  	}
  	if ((missing_type == MissingType::Zero && IsZero(fval))
  	|| (missing_type == MissingType::NaN && std::isnan(fval))) {
  	if (GetDecisionType(decision_type_[node], kDefaultLeftMask)) {
  	return left_child_[node];
  	} else {
  	return right_child_[node];
  	}
  	}
  	if (fval <= threshold_[node]) {
  	return left_child_[node];
  	} else {
  	return right_child_[node];
  	}
  	}

• Categorical Split:

  LightGBM/include/LightGBM/tree.h

  Lines 372 to 388 in 6b695c2

  	inline int CategoricalDecision(double fval, int node) const {
  	int int_fval;
  	if (std::isnan(fval)) {
  	return right_child_[node];
  	} else {
  	int_fval = static_cast<int>(fval);
  	if (int_fval < 0) {
  	return right_child_[node];
  	}
  	}
  	int cat_idx = static_cast<int>(threshold_[node]);
  	if (Common::FindInBitset(cat_threshold_.data() + cat_boundaries_[cat_idx],
  	cat_boundaries_[cat_idx + 1] - cat_boundaries_[cat_idx], int_fval)) {
  	return left_child_[node];
  	}
  	return right_child_[node];
  	}

[shiyu1994]

Thank you for the fix. Quite clear to me!

[github-actions]

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.