[tests][python] Make test that checks original pandas data isn't modified more strict #5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested review from
jmoralez,
jameslamb and
shiyu1994
as code owners
jameslamb
approved these changes
Jun 5, 2022
| @@ -654,16 +654,18 @@ def test_no_copy_when_single_float_dtype_dataframe(dtype, feature_name): | |||
| assert np.shares_memory(X, built_data) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize('feature_name', [['x1'], 'auto']) | |||
| @pytest.mark.parametrize('feature_name', [[42], 'auto']) | |||
There was a problem hiding this comment.
Suggested change
| @pytest.mark.parametrize('feature_name', [[42], 'auto']) | |
| @pytest.mark.parametrize('feature_name', [['x1'], [42], 'auto']) |
Instead of replacing a string with a number here, would you consider adding a case here? That way, this test would still cover the case "feature_name provided, and names are strings".
There was a problem hiding this comment.
Thanks for the proposal! Added in 2b107f6.
There was a problem hiding this comment.
changes look great, thank you!
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, should have proposed that in #5254.
Check that
_data_from_pandas()doesn't modify column names (doesn't convert int to string) of original data.Refer to #5254 (review).