fix typo in CEGB method name #5168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
requested review from
guolinke,
btrotta,
shiyu1994,
hzy46 and
tongwu-sh
as code owners
shiyu1994
approved these changes
Apr 22, 2022
StrikerRUS
approved these changes
Apr 23, 2022
guolinke
approved these changes
Apr 23, 2022
|
closing and re-opening to re-trigger CI, now that #5174 has been merged. |
40 tasks
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing #5164.
I suspect that the method
CostEfficientGradientBoosting::DetlaGain()was supposed to be calledDeltaGain(). This PR proposes fixing that.Notes for Reviewers
This class isn't part of the library's public API, so this is not a user-facing breaking change.
I used the following to search for all such typos: