Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix formula in path smoothing docs (fixes #5139) #5154

Merged
merged 1 commit into from
Apr 15, 2022
Merged

[docs] Fix formula in path smoothing docs (fixes #5139) #5154

merged 1 commit into from
Apr 15, 2022

Conversation

samFarrellDay
Copy link
Contributor

@samFarrellDay samFarrellDay commented Apr 14, 2022

fixes #5139

Very simple change, just 1 line to docs.

@ghost
Copy link

ghost commented Apr 14, 2022

CLA assistant check
All CLA requirements met.

@jameslamb jameslamb changed the title Updated path_smooth documentation. Fixes #5139 [docs] Fix formula in path smoothing docs (fixes #5139) Apr 14, 2022
@jameslamb jameslamb added the doc label Apr 14, 2022
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for taking the time to improve LightGBM! This change looks like it matches the corresponding code that was linked from #5139.

@jameslamb
Copy link
Collaborator

Don't worry about the failing CI jobs. They're unrelated to this PR, and I have a fix up in #5152 to fix them. I'll update this PR after that's merged.

By the way...in the future when you make contributions here or in other open source projects, I strongly recommend using a dedicated branch on your fork, instead of opening a pull request directly from master / main. Once this PR is merged, since we use squash merging here master of this repo will have a conflicting commit history with your fork.

@guolinke
Copy link
Collaborator

close and reopen to rerun CI

@guolinke guolinke closed this Apr 15, 2022
@guolinke guolinke reopened this Apr 15, 2022
@jameslamb jameslamb merged commit fc0c8fd into microsoft:master Apr 15, 2022
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix formula in documentation for path_smooth
3 participants