Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] use 'docker run --rm' in autoconf instructions #5125

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

jameslamb
Copy link
Collaborator

This PR proposes adding --rm to the docker run call in the R package's instructions for re-generating configure using autoconf.

Per the docs for docker run at https://docs.docker.com/engine/reference/run/#clean-up---rm

By default a container’s file system persists even after the container exits. This makes debugging a lot easier (since you can inspect the final state) and you retain all your data by default. But if you are running short-term foreground processes, these container file systems can really pile up. If instead you’d like Docker to automatically clean up the container and remove the file system when the container exits, you can add the --rm flag

If you set the --rm flag, Docker also removes the anonymous volumes associated with the container when the container is remove

Notes for Reviewers

Noticed this because I saw the following on my laptop when running docker container ls --all.

CONTAINER ID   IMAGE          COMMAND   CREATED         STATUS                       PORTS     NAMES
aa8772949750   ubuntu:20.04   "bash"    4 minutes ago   Exited (0) 3 minutes ago               magical_carver
cd0733a5ea46   ubuntu:20.04   "bash"    5 minutes ago   Exited (129) 4 minutes ago             objective_fermi

This is just a small thing that reduces the side effects on local developments of running the development steps mentioned in LightGBM's documentation.

@jameslamb jameslamb added the doc label Apr 4, 2022
@jameslamb jameslamb requested a review from StrikerRUS April 4, 2022 01:40
@jameslamb jameslamb merged commit d811f3a into master Apr 4, 2022
@jameslamb jameslamb deleted the docker-run-rm branch April 4, 2022 19:24
@StrikerRUS
Copy link
Collaborator

@jameslamb
Copy link
Collaborator Author

blegh yes, sorry for missing that one! Yes we should.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants