Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] rename internal callback functions #5123

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

mayer79
Copy link
Contributor

@mayer79 mayer79 commented Apr 3, 2022

Following #5018 (review),
changing the internal callback names:

  • cb.early.stop() --> cb_early_stop()
  • cb.print.evaluation() --> cb_print_evaluation()
  • cb.record.evaluation() --> cb_record_evaluation()

@mayer79 mayer79 changed the title rename internal callback functions [R-package] rename internal callback functions Apr 3, 2022
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

I double-checked like this:

git grep -E "cb\."

and didn't find any other references.

@jameslamb jameslamb merged commit 32a7f10 into microsoft:master Apr 4, 2022
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants