Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package] remove is_reshape argument in Booster.predict (fixes #5115) #5117

Merged
merged 1 commit into from
Apr 2, 2022
Merged

[python-package] remove is_reshape argument in Booster.predict (fixes #5115) #5117

merged 1 commit into from
Apr 2, 2022

Conversation

jmoralez
Copy link
Collaborator

@jmoralez jmoralez commented Apr 1, 2022

Fixes #5115.

@jmoralez
Copy link
Collaborator Author

jmoralez commented Apr 1, 2022

is_reshape seemed like it could be removed from the _InnerPredictor as well but if the idea was only removing it from the Booster I'll undo those changes.

StrikerRUS
StrikerRUS approved these changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

jameslamb
jameslamb approved these changes Apr 2, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

from the _InnerPredictor as well but if the idea was only removing it from the Booster I'll undo those changes.

I totally support removing this in _InnerPredictor.predict() too. I only mentioned Booster explicitly in #5115 because I thought the description should be focused on the proposed changes to the package's public API.

@jameslamb jameslamb merged commit 7820746 into microsoft:master Apr 2, 2022
@jmoralez jmoralez deleted the remove-is_reshape branch April 2, 2022 05:02
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@jameslamb jameslamb jameslamb approved these changes

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@hzy46 hzy46 Awaiting requested review from hzy46

@tongwu-sh tongwu-sh Awaiting requested review from tongwu-sh

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[python-package] remove is_reshape in Booster.predict()
3 participants
@jmoralez @jameslamb @StrikerRUS