[R-package] add assertions to test on lightgbm() weights #5110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the following today in the logs for the R package's tests.
This is coming from a test added recently (#4975). I guess that
{testthat}
skips tests that don't have anyexpect_*
calls in them. It looks like this has been the behavior of that package since 2016 (r-lib/testthat#413), I just never noticed it before.This PR adds assertions to the relevant test, to ensure that it's run.
Notes for Reviewers
You can check the
MSVC
R-package CI jobs to see the logs from tests, since for those the CI runsRscript testthat.R
instead ofR CMD check
.