[CUDA] Fix row-wise histogram construction with dense data matrix #5103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently row-wise histogram construction cannot run successfully with dense data matrix. The check
row_ptr_bit_type
should be skipped here for dense data matrix,LightGBM/src/treelearner/cuda/cuda_histogram_constructor.cu
Lines 280 to 288 in 60e72d5
In addition, we disable the use of multi-value feature group in
cuda_exp
for now in this PR. Because we don't have an implementation of sparse bin currently, thus using multi-value feature group can be too costly for GPU memory. We force the feature groups to be single-value.