-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Promote objective and init_score to top-level arguments in lightgbm()
#4976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I support adding init_score
and objective
as keyword arguments in lightgbm()
. Please see the requested changes.
Co-authored-by: James Lamb <[email protected]>
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the tests! Please see my most recent requested changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much! I think this is almost ready to merge, just a few more recommended changes.
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! Just one more suggestion and this can be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just updated this with the latest changes from master
, now that #5021 has been merged.
I'll merge this once it builds. Thanks very much for the contribution!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
ref #4968
This PR promotes
objective
andinit_score
to top-level parameters inlightgbm()
. This is for 3 reasons:objective
is probably one of the most common parameters to want to change. It's also accepted as a top-level parameter in thelgb.train
interface and in the scikit-learn interface.objective
as a top-level parameter will allow an option"auto"
in the future (as part of [R-package] User-friendly redesign forlightgbm()
#4968) to adjust it automatically for binary and multi-class classification depending on the input.init_score
as a top-level parameter will allow to take it as a column from the input data in the future (as part of [R-package] User-friendly redesign forlightgbm()
#4968), even if it right now looks out of place.