Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] [dask] fix mypy error about worker_addresses #4851

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Dec 4, 2021

Contributes to #3867.

This PR fixes a mypy error in dask.py

python-package/lightgbm/dask.py:726: error: Argument "worker_addresses" to "_machines_to_worker_map" has incompatible type "KeysView[Any]"; expected "List[str]"

Confirmed that this suppresses the error by running the following.

mypy \
    --exclude='python-package/compile/|python-package/build' \
    --ignore-missing-imports \
    python-package/

@jameslamb jameslamb merged commit 3dcb36e into master Dec 6, 2021
@jameslamb jameslamb deleted the mypy-dask-iterable branch December 6, 2021 16:42
@StrikerRUS StrikerRUS mentioned this pull request Jan 6, 2022
13 tasks
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants