-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] indicate support of Monterey #4732
Conversation
CI is failing with
This is because Mojave is used at our macOS CI worker:
I suggest to keep Mojave support for now then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I agree with your interpretation of "last 3 major versions".
Just to clarify, right now due to the restrictions of our CI (#4732 (comment)) we are supporting "last 4 major versions", not 3. We may consider migrating to a newer macOS builder like XGBoost recently did: dmlc/xgboost#7382. Line 7 in dcae8dd
because the minimum available version of Xcode at macos-10.15 builder is 10.3 https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode And I don't know whether new artifacts will remain backward compatible. |
Got it, yep thanks for the further explanation. Makes sense to me. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
According to the policy, we indicate support only for the last 3 macOS versions in wheel name: #2691 (comment).
I believe that "the last 3 macOS versions" means 3 last major releases like it was before 11.x
Successfully built bottles for
arm64_monterey
,arm64_big_sur
,monterey
,big_sur
,catalina
,mojave
by Homebrew team give some confidence in that LightGBM is indeed compatible with the wide range of macOS versions.https://github.com/Homebrew/homebrew-core/blob/4060c0ab42d8b9b7168b34f55f12e16a91b27150/Formula/lightgbm.rb#L10-L15
Just FYI, it is now possible to provide one
universal2
wheel for bothx86_64
andarm64
.